Return Comm rather than BaseComm from create_comm#1091
Return Comm rather than BaseComm from create_comm#1091matthewturk wants to merge 3 commits intoipython:anyiofrom
Conversation
|
It looks like the failure is in My intuition doesn't have much to say about if this is related. |
|
It seems to be an intermittent failure. I saw it in #1089, but then it passed on the merge commit. I just kicked it. |
|
|
||
| def _create_comm(*args, **kwargs): | ||
| """Create a new Comm.""" | ||
| return BaseComm(*args, **kwargs) |
There was a problem hiding this comment.
Ah, I misunderstood what you intended to change. We wanted to explicitly return BaseComm here because it is more efficient. I think the right answer is for ipywidgets to relax its expected trait.
There was a problem hiding this comment.
yeah, BaseComm is 'the new thing', Comm is for backwards compatibility with ipywidgets.
There was a problem hiding this comment.
I see, but since ipywidgets doesn't accept BaseComm should that be the submitted change? I guess I'm confused because @blink1073's suggestion seemed straightforward, but now I don't understand how to interpret @maartenbreddels's reply.
3 participants
This replaces
BaseCommincreate_commwithComm, which should match what is expected byipywidgetsfor validation of thecommtrait in subclasses ofipywidgets.Widget.Fixes #1090 .